Install Composer dependencies in release script#19
Open
Conversation
The release script was missing a composer install step, so releases could be built without production dependencies bundled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Proposed changes:
composer run releasestep to install production-only Composer dependencies before building a release commit.vendor/(which is gitignored) so production dependencies are included in the release branch.Other information:
Testing instructions:
node bin/release.jsand verify the release commit includes thevendor/directory with only production dependencies.Changelog entry
Changelog Entry Details
Significance
Type
Message
Install production Composer dependencies before building release packages.