Skip to content

feat(settings): Experimental Tools framework (NPPM-2692)#4591

Open
adekbadek wants to merge 3 commits intotrunkfrom
nppm-2692-experimental-tools-infrastructure
Open

feat(settings): Experimental Tools framework (NPPM-2692)#4591
adekbadek wants to merge 3 commits intotrunkfrom
nppm-2692-experimental-tools-infrastructure

Conversation

@adekbadek
Copy link
Member

Summary

Adds the generic Experimental Tools framework to newspack-plugin: a filter-based tool registration system, REST API, and a new Settings tab with CardFeature-based UI.

Full details, video walkthroughs, and test plan in the companion PR:
https://github.com/Automattic/newspack-manager/pull/529

🤖 Generated with Claude Code

@adekbadek adekbadek force-pushed the nppm-2692-experimental-tools-infrastructure branch from 3cc63bd to 2f6d120 Compare March 23, 2026 11:49
@adekbadek adekbadek requested a review from Copilot March 23, 2026 11:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Introduces a new “Experimental Tools” framework to Newspack Settings: external plugins can register tools via a filter, Newspack persists per-tool state in an option, exposes REST endpoints for toggling/saving settings, and adds a new Settings tab with a CardFeature-based UI and configuration view.

Changes:

  • Added Experimental_Tools PHP manager (filter registration, option storage, REST API, usage tracking) and wired it into plugin includes + Newspack Settings tab data.
  • Added a new Settings UI section (experimental-tools) with enable modal + per-tool configure form, plus supporting TS types and styles.
  • Updated CardFeature styling to better support equal-height cards / action row placement; added unit tests for the new PHP framework.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
includes/experimental-tools/class-experimental-tools.php Core framework: registration, persistence, REST routes, accessors, usage tracking.
includes/class-newspack.php Loads the new Experimental Tools class.
includes/wizards/newspack/class-newspack-settings.php Adds “Experimental tools” settings tab when tools are registered.
src/wizards/newspack/views/settings/sections.tsx Lazily loads the new experimental-tools settings section.
src/wizards/newspack/views/settings/experimental-tools/index.tsx Main UI list + configure route switching and REST interactions.
src/wizards/newspack/views/settings/experimental-tools/configure-view.tsx Per-tool configuration form and client-side validation.
src/wizards/newspack/views/settings/experimental-tools/enable-modal.tsx Enable confirmation modal for tools.
src/wizards/newspack/views/settings/experimental-tools/types.ts Type definitions for tool + field schema.
src/wizards/newspack/views/settings/experimental-tools/style.scss Styles for the configure view / display fields.
packages/components/src/card-feature/style.scss Layout adjustments for CardFeature.
tests/unit-tests/experimental-tools.php Unit tests for registration, toggling, metadata, field saving, and usage tracking.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@adekbadek adekbadek force-pushed the nppm-2692-experimental-tools-infrastructure branch 2 times, most recently from 64eeccc to 6dc7841 Compare March 23, 2026 13:17
@adekbadek adekbadek force-pushed the nppm-2692-experimental-tools-infrastructure branch from 6dc7841 to 72109e8 Compare March 23, 2026 13:52
@adekbadek adekbadek marked this pull request as ready for review March 23, 2026 21:14
@adekbadek adekbadek requested a review from a team as a code owner March 23, 2026 21:14
@adekbadek adekbadek added the [Status] Needs Review The issue or pull request needs to be reviewed label Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Status] Needs Review The issue or pull request needs to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants