[Task-2247] Named Browser Sessions For Dual-Driver Browser Instances#671
Open
nasif-z wants to merge 13 commits intoreq-81-playwright-selenium-dual-driverfrom
Open
[Task-2247] Named Browser Sessions For Dual-Driver Browser Instances#671nasif-z wants to merge 13 commits intoreq-81-playwright-selenium-dual-driverfrom
nasif-z wants to merge 13 commits intoreq-81-playwright-selenium-dual-driverfrom
Conversation
Similar to Selenium open browser action
Member
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e8e79d1b04
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Member
|
@nasif-z check the comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces session-based browser isolation to allow testers to easily spawn fresh browser windows and intuitively interact with them individually. It follows the same session model used in database actions.
Changes
browser_sessionsshared variable to hold necessary browser driver information whenever opening new browser windows. By default, generates abrowser_sessionnameddefault.sessionparameter to only execute the actions on specific instances without affecting others.Backwards Compatibility
sessionparameter is omitted, the framework defaults to the legacy single-instance behavior.driveridsupport is maintained for Selenium.Usage
Add row in action in this format:
session|optional parameter|session name (string)1. Selenium Multi-Session
Pass a unique string to the
sessionparameter to spawn separate windows.2. Apply action on specific session
3. Specific Session Cleanup
4. Without "session" parameter
Omitting the
sessionparameter in step/action data will preserve the behavior as it was before the addition of this feature.