[Req-81] Playwright-Selenium Dual-Driver Implementation#670
Open
nasif-z wants to merge 6 commits intoplaywright-asyncfrom
Open
[Req-81] Playwright-Selenium Dual-Driver Implementation#670nasif-z wants to merge 6 commits intoplaywright-asyncfrom
nasif-z wants to merge 6 commits intoplaywright-asyncfrom
Conversation
Member
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7bf65e1a4d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Framework/Built_In_Automation/Sequential_Actions/sequential_actions.py
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runtime Parameter:
BROWSER_DRIVERplaywrightorseleniumselenium action-BROWSER_DRIVERis set toplaywright- all those actions will be converted toplaywright actioninternally by Node at runtimeOptional Parameter:
browser driverThis works similarly to the runtime parameter above but this takes the highest priority when both parameters are in place. This is meant to override the driver preference only for certain actions, allowing the user to have fine-grained driver selection for their steps even when using the runtime parameter to set a global driver preference.
browser driver|optional parameter|playwrightorseleniumselenium action- and if this optional parameter is set toplaywright- the action will be converted toplaywright actioninternally by NodeSeamless driver switching
playwright actionto run on Selenium-launched browsers andselenium actionto run on Playwright-launched browsers