Skip to content

test: cover abstract method pass lines for 100% coverage#31

Merged
TheRealAgentK merged 1 commit intorelease/2.0.0from
na/test-abstract-coverage
Apr 10, 2026
Merged

test: cover abstract method pass lines for 100% coverage#31
TheRealAgentK merged 1 commit intorelease/2.0.0from
na/test-abstract-coverage

Conversation

@NinosMan
Copy link
Copy Markdown
Contributor

@NinosMan NinosMan commented Apr 10, 2026

test: cover abstract method pass lines for 100% coverage

Description 📝

  • Purpose: Achieve 100% code coverage by covering the pass bodies of abstract base class methods (ActionHandler.execute, PollingTriggerHandler.poll, ConnectedAccountHandler.get_account_info).
  • Approach: Add three tests that subclass each ABC, call super().method(), and assert the return value is None.

Type of change

  • New feature (non-breaking change which adds functionality)

Updates

👉 Add test_action_handler_abstract_execute_returns_none
👉 Add test_polling_trigger_handler_abstract_poll_returns_none
👉 Add test_connected_account_handler_abstract_get_account_info_returns_none

Screenshots 📷

N/A

Test plan 🧪

  • Run pytest --cov and verify 100% coverage

Author(s) to check 👓

  • Project and all contained modules builds successfully
  • Self-/dev-tested
  • Unit/UI/Automation/Integration tests provided where applicable
  • Code is written to standards
  • Appropriate documentation written (code comments, internal docs)

Reviewer(s) to check ✔️

  • Project and all contained modules builds successfully
  • Change has been dev-/reviewer-tested, where possible
  • Unit/UI/Automation/Integration tests provided where applicable
  • Code is written to standards
  • Appropriate documentation written (code comments, internal docs)

@NinosMan NinosMan requested a review from TheRealAgentK April 10, 2026 02:22
@github-actions
Copy link
Copy Markdown

Coverage — be331b7 (test: cover abstract method pass lines for 100% coverage) by @NinosMan

Total coverage: 100%

File Stmts Miss Cover Missing
src/autohive_integrations_sdk/__init__.py 2 0 100%
src/autohive_integrations_sdk/integration.py 358 0 100%

@NinosMan NinosMan changed the base branch from master to release/2.0.0 April 10, 2026 02:23
Copy link
Copy Markdown
Collaborator

@TheRealAgentK TheRealAgentK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheRealAgentK TheRealAgentK merged commit 5de64ea into release/2.0.0 Apr 10, 2026
1 check passed
@TheRealAgentK TheRealAgentK deleted the na/test-abstract-coverage branch April 10, 2026 04:42
@github-actions github-actions bot mentioned this pull request Apr 10, 2026
TheRealAgentK added a commit that referenced this pull request Apr 10, 2026
* chore: prepare release 2.0.0

* Soften migration guide wording

* test: cover abstract method pass lines for 100% coverage (#31)

---------

Co-authored-by: NinosMan <84176904+NinosMan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants