feat: update organism schema and refine assembly versioning#13
Merged
feat: update organism schema and refine assembly versioning#13
Conversation
…en we fetch data from NCBI)
…t optimal sample for tax_id
…id for for /cancel
# Conflicts: # app/api/v1/endpoints/assemblies.py # tests/unit/endpoints/test_endpoints_assemblies.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
This PR tightens the assembly intent lifecycle to make reservations and cancellations explicit and safer under concurrent use.
The intent endpoint now returns a structured JSON envelope including
assembly_run_idandmanifest_yaml, and cancellation now targets a specific reservation byassembly_run_idinstead of cancelling the latest run implicitly. It also consolidates specimen sample selection logic through the optimal-sample helper and keeps intent body optional.🔄 Type of Change
🧩 Key Changes
POST /api/v1/assemblies/intent/{tax_id}to return JSON envelope:assembly_run_id,version,status,manifest_yamltol_id.POST /api/v1/assemblies/intent/{tax_id}/cancelnow requiresassembly_run_idin request body (optionalversionguard).AppError(409) on version mismatch._get_manifest_inputs_by_tax_idnow delegates to_get_optimal_sample_id_for_tax_id.✅ Checklist
🔍 Review Notes
POST /assemblies/intent/{tax_id}response is now JSON (not raw YAML body).POST /assemblies/intent/{tax_id}/cancelnow requires body payload withassembly_run_id.📎 Related Issues / Tickets