[AAG] Fixes to Astral Elf and Wildspacer

[JarodHuber]

Added TCOE proficiency replacer to Astral Elf's Keen Senses
Removed Language proficiencies from Wildspacer background

Removed grant ID_INTERNAL_GRANT_RACE_ELF as it is redundant
Moved rules around to match the order in MOTM races

[NickVendel]

I think we might've fixed Astral Elf in PHB24 PR, but it shouldn't matter for this PR.

[NickVendel]

this is a mess. I recommend just updating this branch's file with the one from the master, increment version of the file and then add your fix for Keen Senses. That should work much better and won't delete relevant Grant either.

[JarodHuber]

I can move Darkvision back down to match PHB24 and rewrite the language grant to match as well (select 2 on customized language option). But ID_INTERNAL_GRANT_RACE_ELF is redundant with ID_INTERNAL_RACIAL_TRAIT_TYPE_HUMANOID_ELF, which is at the top to coincide with PHB24 organization. I'm a bit surprised to see it's not utilized in the PHB24 races.

[NickVendel]

You're right about the Grant, we probably missed the original TYPE_HUMANOID one. So yeah, we can remove the redundant one, but i do think everything else should be in the same format as it is now, just because it's messy either way in my opinion, so it's better not to move anything.

I can move Darkvision back down to match PHB24

You don't need to match PHB24, better would be to match AAG. Which would probably require you to move Languages above, after ASI. Then moving Creature type under it as well, above Size, and then move Darkvision below Astral Fire. But just to be clear, it's an optional thing, we technically don't need to move anything in this PR, it works as is (though redundant Grant should be removed).

I'm a bit surprised to see it's not utilized in the PHB24 races.

Which ones need it? I feel like none of them are "considered as", they're just Humanoid of their related species.

[JarodHuber]

The reason to match the PHB24 format is to have a consistent format. Even if it's messy, having a standard, consistent way the rules are granted improves the readability and helps prevent errors like missing the TYPE_HUMANOID grant. That said, I won't harp on that point and will revert that part as it's not for me to decide something like that. As for the PHB24 races, you're right, I guess I just figured they would be used for clarity. Shall I still rewrite the customized language grant from Tasha's to override both language grants and be a 'select 2'?

[NickVendel]

Even if it's messy, having a standard

Our standard is a book standard. The reason why i, personally, wanted a standard for PHB24 is because 1) i assume plenty of official books afterward will use that standard or at least something fairly close to it (same goes for third-party and homebrew content) and 2) because original PHB was created by the dev, so there's lots of weird decisions that i wanted to get around in order to get closer to book format. Books before PHB24 are kinda all over the place, and while i can see how having a standard can improve readability for the coder, i still think it's much easier to compare to the book when it's all in order that is in the book, so that's kinda my go-to format with any source.

Shall I still rewrite the customized language grant from Tasha's to override both language grants and be a 'select 2'?

I think there's no reason, since that second one is already basically TCOE logic, i think only Common is fine.

[JarodHuber]

Oh, I see what you mean now. Yeah, I guess that makes sense. I was only considering book accuracy from the end user's PoV. In that case, shouldn't Darkvision be under Astral Fire and Speed under Size?

[NickVendel]

that's what i said in the comment just before previous one (in the edit)