Skip to content

Fix node selection test #13817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raymondjacobson merged 1 commit into from
Mar 5, 2026
Merged

Fix node selection test #13817

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 3 additions & 17 deletions packages/sdk/src/sdk/services/StorageNodeSelector/StorageNodeSelector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,12 +89,9 @@ export class StorageNodeSelector implements StorageNodeSelectorService {
this.selectedNode = selectedNode
this.logger.info('Selected content node', this.selectedNode)
} else {
// No healthy nodes found. Fall back to a random node
this.selectedNode = this.getRandomNode()
this.logger.warn(
'No healthy nodes found. Falling back to random node:',
this.selectedNode
)
// No healthy nodes found
this.selectedNode = null
this.logger.warn('No healthy nodes found')
this.selectionState = 'failed_all'
}

Expand Down Expand Up @@ -130,17 +127,6 @@ export class StorageNodeSelector implements StorageNodeSelectorService {
return selectedNode
}

private getRandomNode(): string | null {
if (!this.orderedNodes?.length) {
this.orderedNodes = this.orderNodes(new Date().toString())
}
if (this.orderedNodes.length === 0) {
return null
}
const randomIndex = Math.floor(Math.random() * this.orderedNodes.length)
return this.orderedNodes[randomIndex] ?? null
}

private orderNodes(key: string) {
const endpoints = this.nodes.map((node) => node.endpoint.toLowerCase())
const hash = new RendezvousHash(...endpoints)
Expand Down