Remove dead EthereumContract base class, getDefaultConfig helper, and clean up types#13801
Remove dead EthereumContract base class, getDefaultConfig helper, and clean up types#13801rickyrombo merged 2 commits intomjp-ethfrom
Conversation
|
…p types.ts Co-authored-by: rickyrombo <3690498+rickyrombo@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Removes unreferenced Ethereum contract scaffolding that became obsolete after the refactor to pass ethPublicClient directly into each contract client’s config, and cleans up now-unused types/imports.
Changes:
- Deleted
EthereumContract.ts(unused base class). - Deleted
getDefaultConfig.ts(unusedgetDefaultEthereumClientConfighelper). - Simplified
types.tsby removing the unusedEthereumContractConfigInternaltype and its imports.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
packages/sdk/src/sdk/services/Ethereum/contracts/types.ts |
Removes now-dead config type/imports; leaves only GasFeeSchema. |
packages/sdk/src/sdk/services/Ethereum/contracts/getDefaultConfig.ts |
Removes unused default Ethereum client config helper. |
packages/sdk/src/sdk/services/Ethereum/contracts/EthereumContract.ts |
Removes unused base class that previously created a viem public client. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
EthereumContractConfigInternal, theEthereumContractbase class, andgetDefaultEthereumClientConfigwere left unreferenced after the refactor to passethPublicClientdirectly into each contract client's config. Also fixesPublicClientbeing imported as a value instead of a type intypes.ts.Changes
EthereumContract.ts— abstract base class with no subclasses; superseded by the per-contractethPublicClientconfig patterngetDefaultConfig.ts—getDefaultEthereumClientConfigwas never called anywhere after the refactortypes.ts— removedEthereumContractConfigInternal(only referenced by the now-deleted files) and its unusedviemimport✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.