Skip to content

Remove dead EthereumContract base class, getDefaultConfig helper, and clean up types#13801

Merged
rickyrombo merged 2 commits intomjp-ethfrom
copilot/sub-pr-13800
Mar 3, 2026
Merged

Remove dead EthereumContract base class, getDefaultConfig helper, and clean up types#13801
rickyrombo merged 2 commits intomjp-ethfrom
copilot/sub-pr-13800

Conversation

Copy link

Copilot AI commented Mar 3, 2026

EthereumContractConfigInternal, the EthereumContract base class, and getDefaultEthereumClientConfig were left unreferenced after the refactor to pass ethPublicClient directly into each contract client's config. Also fixes PublicClient being imported as a value instead of a type in types.ts.

Changes

  • Deleted EthereumContract.ts — abstract base class with no subclasses; superseded by the per-contract ethPublicClient config pattern
  • Deleted getDefaultConfig.tsgetDefaultEthereumClientConfig was never called anywhere after the refactor
  • types.ts — removed EthereumContractConfigInternal (only referenced by the now-deleted files) and its unused viem import

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@changeset-bot
Copy link

changeset-bot bot commented Mar 3, 2026

⚠️ No Changeset found

Latest commit: 5493ddb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

…p types.ts

Co-authored-by: rickyrombo <3690498+rickyrombo@users.noreply.github.com>
@pull-request-size pull-request-size bot added size/M and removed size/XS labels Mar 3, 2026
Copilot AI changed the title [WIP] WIP Address feedback on eth refactor PR Remove dead EthereumContract base class, getDefaultConfig helper, and clean up types Mar 3, 2026
@rickyrombo rickyrombo requested a review from Copilot March 3, 2026 06:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes unreferenced Ethereum contract scaffolding that became obsolete after the refactor to pass ethPublicClient directly into each contract client’s config, and cleans up now-unused types/imports.

Changes:

  • Deleted EthereumContract.ts (unused base class).
  • Deleted getDefaultConfig.ts (unused getDefaultEthereumClientConfig helper).
  • Simplified types.ts by removing the unused EthereumContractConfigInternal type and its imports.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
packages/sdk/src/sdk/services/Ethereum/contracts/types.ts Removes now-dead config type/imports; leaves only GasFeeSchema.
packages/sdk/src/sdk/services/Ethereum/contracts/getDefaultConfig.ts Removes unused default Ethereum client config helper.
packages/sdk/src/sdk/services/Ethereum/contracts/EthereumContract.ts Removes unused base class that previously created a viem public client.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rickyrombo rickyrombo marked this pull request as ready for review March 3, 2026 06:08
@rickyrombo rickyrombo merged commit 6f10f49 into mjp-eth Mar 3, 2026
7 checks passed
@rickyrombo rickyrombo deleted the copilot/sub-pr-13800 branch March 3, 2026 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants