Conversation
|
Thanks for taking the time to contribute to this project. Upload Assistant is currently in a complete rewrite, and no new development is being conducted on this python source at this time. If you have come this far, please feel free to leave open, any pull requests regarding new sites being added to the source, as these can serve as the baseline for later conversion. If your pull request relates to a critical bug, this will be addressed in this code base, and a new release published as needed. If your pull request only addresses a quite minor bug, it is not likely to be addressed in this code base. Details for the new code base will follow at a later date. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe pull request extends AZTrackerBase.get_file_info to handle DVD discs by locating the largest Changes
Sequence Diagram(s)sequenceDiagram
participant Tracker as AZTrackerBase
participant FS as Filesystem (glob/stat)
participant MI as MediaInfo
Tracker->>FS: glob for VTS_*.VOB under meta["path"]
FS-->>Tracker: list of VOB files
Tracker->>FS: stat files to determine largest
FS-->>Tracker: largest VOB path
Tracker->>MI: MediaInfo.parse(largest_vob, output="STRING")
MI-->>Tracker: parsed media info string
Tracker-->>Tracker: return parsed string from get_file_info()
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/trackers/AVISTAZ_NETWORK.py`:
- Around line 377-382: The DVD VOB glob is case-sensitive and uses "**/*.vob",
so on Linux it misses uppercase VOB files; update the pattern where
meta.get("is_disc") == "DVD" (the block that populates vob_files and computes
largest_vob) to match uppercase extensions (e.g., "**/*.VOB") or perform a
case-insensitive match (e.g., glob both "*.VOB" and "*.vob" or normalize via
os.listdir and filter by lowercased suffix) before calling MediaInfo.parse on
largest_vob; ensure you adjust only the glob call that produces vob_files to use
the uppercase pattern consistent with other code (e.g., VTS_*.VOB).
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 81143a0f-d755-4712-8aa1-815e3e2a3a8b
📒 Files selected for processing (1)
src/trackers/AVISTAZ_NETWORK.py
|
vob_mi is already in meta. They probably want both ifo and vob tbh. vob does not have correct runtime or language details. edit: vob only has accurate details about that vob also, not the entire disc. |
Summary by CodeRabbit