Upgrade nemomobile dependencies#209
Merged
FlorentRevest merged 72 commits intoAsteroidOS:masterfrom Apr 24, 2026
Merged
Conversation
casept
force-pushed
the
rebase-nemomobile
branch
from
080f5b9 to
f3a6c20
Compare
Contributor
Author
|
Checklist (build):
Checklist (smoke test): |
casept
force-pushed
the
rebase-nemomobile
branch
2 times, most recently
from
bebbd2a to
15c51d7
Compare
casept
force-pushed
the
rebase-nemomobile
branch
4 times, most recently
from
a4cb740 to
ac030d4
Compare
casept
force-pushed
the
rebase-nemomobile
branch
2 times, most recently
from
2de2813 to
d85503a
Compare
MagneFire
force-pushed
the
master
branch
2 times, most recently
from
d83c298 to
dd515ab
Compare
casept
force-pushed
the
rebase-nemomobile
branch
5 times, most recently
from
b61143b to
ddf88b6
Compare
Contributor
Author
|
Builds now and boots. Problems on
|
Member
|
Thanks a lot for all this work :) as I'm scanning old ignored pull requests I stumbled upon AsteroidOS/lipstick#22 is this something you ran into ? |
Contributor
Author
Seems so, see build log at https://gist.githubusercontent.com/casept/fbf6c3df58259c6807b2e31d2b01804d/raw/dc3bf8241aade080d530ced441081d0a6b4eaa10/gistfile1.txt Among others: For now, I just patched out Werror in the hopes that lipstick cleanup can be postponed. |
casept
force-pushed
the
rebase-nemomobile
branch
2 times, most recently
from
1e88f8b to
6cf0f6c
Compare
Member
Yeah, just pick the path of least resistance to deal with lipstick for now. Just for context, lipstick has been on a jumping seat for a while already. There seems to be a lot of its code that we don't use at all and we have forked it quite heavily already so we're not getting much benefit from upstream anyway so I'd envision that in a not so distant future we'd merge all the parts of its code which we really use into asteroid-launcher and have the two projects be merged into one codebase that is more minimal for what we actually do with it. As part of this, I'm sure there's a lot of concepts that could get cleaned up and asteroid-launcher would hopefully look like a more regular user of QtWayland (or QtApplicationLauncher ?) and that dependency would eventually disappear. This is not a small refactoring but maybe that bit of context can help you take certain shortcuts. |
Member
|
This is looking pretty great :) with the last 3 comments addressed, it's good to merge. Thanks a lot again! I realize how time consuming this is but is very valuable, I really appreciate the time you poured into this! :) |
Member
|
Ah also most of your recent commits are committed by "Your Name" - it's not a big deal but maybe you want to fix that |
Member
|
Mh this also appears to be broken: |
Member
|
That seems to be caused by You probably want to use just |
Needed by newer version of libngf-qt
Drop one of our patches that has been accepted upstream.
Requires removing Werror. We should probably eventually just properly rebase it so that all the deprecation warnings go away, but that's a bigger effort.
We don't use it for anything, and it pulls in a large number of dependencies not used by anything else. Therefore, remove it as part of the general upgrade effort.
Upstream has removed support for Android <= 10. All our ports target older Android, so replace with the legacy version of this module.
FlorentRevest
force-pushed
the
rebase-nemomobile
branch
from
c66a277 to
941ca20
Compare
Contributor
Author
|
@FlorentRevest thanks for pushing this over the finish line. |
Member
|
Thank you for doing 99% of the work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs to be done in preparation for upgrading to Qt6, as upstream has recently started adding support for it.
The plan is to go through recipes one-by-one and sync with upstream as I have time for. Help is welcome.