Skip to content

Fix plan stream in eagle worker v2#203

Closed
silencejade wants to merge 4 commits intoAscend:release/PoC_20260331from
silencejade:br_fix_plan_stream
Closed

Fix plan stream in eagle worker v2#203
silencejade wants to merge 4 commits intoAscend:release/PoC_20260331from
silencejade:br_fix_plan_stream

Conversation

@silencejade
Copy link
Copy Markdown

Motivation

When using the Eagle Worker V2, the prepare_for_v2_verify function relies on batch.spec_info.positions to compute next_input_positions on the planning stream. However, batch.spec_info.positions is created and calculated within the build_tree_kernel_efficient function, which executes on the main stream. This results in a synchronization issue between the two streams.

Modifications

Insert a synchronization event for build_tree_kernel_efficient prior to executing prepare_for_v2_verify.

Accuracy Tests

Speed Tests and Profiling

Checklist

Review and Merge Process

  1. Ping Merge Oncalls to start the process. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments or contact authorized users to do so.
    • Common commands include /tag-and-rerun-ci, /tag-run-ci-label, /rerun-failed-ci
  4. After green CI and required approvals, ask Merge Oncalls or people with Write permission to merge the PR.

@ascend-robot
Copy link
Copy Markdown

CLA Signature Guide

@silencejade , thanks for your pull request.

The following commit(s) are not associated with a signed Contributor License Agreement (CLA).

Commit Reason
508e3ccc fix plan stream in eagle worker ... the email used in the commit is not linked to a signed CLA!
please verify that it matches the email you used when signing the CLA.

To sign CLA, click here.

To check if your email is configured correctly, refer to the FAQs.

Once you've signed the CLA or updating your email, please comment /check-cla to revalidate CLA status.

@silencejade silencejade marked this pull request as draft April 6, 2026 12:47
@ascend-robot
Copy link
Copy Markdown

CLA Signature Guide

@silencejade , thanks for your pull request.

The following commit(s) are not associated with a signed Contributor License Agreement (CLA).

Commit Reason
86ed5151 fix plan stream in eagle worker ... the email used in the commit is not linked to a signed CLA!
please verify that it matches the email you used when signing the CLA.

To sign CLA, click here.

To check if your email is configured correctly, refer to the FAQs.

Once you've signed the CLA or updating your email, please comment /check-cla to revalidate CLA status.

@github-actions github-actions Bot added the npu label Apr 7, 2026
@silencejade silencejade marked this pull request as ready for review April 7, 2026 12:11
Hexq0210
Hexq0210 previously approved these changes Apr 7, 2026
@ascend-robot
Copy link
Copy Markdown

CLA Signature Guide

@silencejade , thanks for your pull request.

The following commit(s) are not associated with a signed Contributor License Agreement (CLA).

Commit Reason
86ed5151 fix plan stream in eagle worker ... the email used in the commit is not linked to a signed CLA!
please verify that it matches the email you used when signing the CLA.

To sign CLA, click here.

To check if your email is configured correctly, refer to the FAQs.

Once you've signed the CLA or updating your email, please comment /check-cla to revalidate CLA status.

@silencejade silencejade closed this Apr 8, 2026
@silencejade silencejade deleted the br_fix_plan_stream branch April 17, 2026 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants