Unify device and priority dimension order in stream pool management#92
Open
rauletorresc wants to merge 1 commit intoAscend:masterfrom
Open
Unify device and priority dimension order in stream pool management#92rauletorresc wants to merge 1 commit intoAscend:masterfrom
rauletorresc wants to merge 1 commit intoAscend:masterfrom
Conversation
**Descrition of the problem** Currently, `npu_counters` and `npu_streams` multi-dimensional arrays have priority as the major dimension enclosing the minor device and stream dimensions, e.g. `npu_streams[priority_id][device_id][stream_id]`. However `device_priority_flags` has priority and device interchanged. Moreover, iterating through `npu_streams` is made inefficiently, with the inner loop iterating through the outermost dimension, an the outer loop iterating through the innermost dimension. **Proposed solution** * Make `npu_counters` and `npu_streams` follow `device_priority_flags` dimension order, e.g. `npu_streams[device_id][priority_id][stream_id]`. * Rearrange loops so they follow and exploit the row-major order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem
Currently,
npu_countersandnpu_streamsmulti-dimensional arrays have priority as the major dimension enclosing the minor device and stream dimensions, e.g.npu_streams[priority_id][device_id][stream_id]. Howeverdevice_priority_flagshas priority and device interchanged. Moreover, iterating throughnpu_streamsis made inefficiently, with the inner loop iterating through the outermost dimension, an the outer loop iterating through the innermost dimension.Proposed solution
npu_countersandnpu_streamsfollowdevice_priority_flagsdimension order, e.g.npu_streams[device_id][priority_id][stream_id].