mavlink: use the 'all' dialect everywhere instead of ardupilotmega#39
Merged
Conversation
binlog.cpp included the ardupilotmega dialect header while the rest of the proxy (mavlink_msgs.h) already used the 'all' dialect. Switch binlog.cpp and the pytest harness over to 'all' so a single dialect is used throughout: the include in binlog.cpp, the MAVLINK_DIALECT env var in the test modules, and the pymavlink dialect imports in test_binlog_capture.py. MAV_AUTOPILOT_ARDUPILOTMEGA references are left as-is: that's an autopilot-type enum constant present in the 'all' dialect, not a dialect selection. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
binlog.cpp included the ardupilotmega dialect header while the rest of the proxy (mavlink_msgs.h) already used the 'all' dialect. Switch binlog.cpp and the pytest harness over to 'all' so a single dialect is used throughout: the include in binlog.cpp, the MAVLINK_DIALECT env var in the test modules, and the pymavlink dialect imports in test_binlog_capture.py.
MAV_AUTOPILOT_ARDUPILOTMEGA references are left as-is: that's an autopilot-type enum constant present in the 'all' dialect, not a dialect selection.