Distance limit#136
Open
tugbakara wants to merge 5 commits into
Open
Conversation
wxmerkt
requested changes
Nov 18, 2022
Collaborator
wxmerkt
left a comment
wxmerkt
left a comment
There was a problem hiding this comment.
We cannot merge this as it's a hard-coded parameter which is unlikely to be useful for the majority of users.
Author
Yeap, I know that's why I will add parameter in launch file that user can make change. |
Author
|
sorry for the latency, Now the pr is ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To limit the detection of april tags into ros side I have added if statement taking the distance from ros (pose.pose.pose.position.z) and limit this distance related to tag type.
EDIT: I will provide param distance values related to apriltag dimensions in launch file.
TODO
distance-size rates
parameter addition - I
parameter addition - II
parameter addition - III