[og] Add backside screw hole w/ revised chamfer handlings#133
Open
ClassicOldSong wants to merge 4 commits intoAndyLevesque:mainfrom
Open
[og] Add backside screw hole w/ revised chamfer handlings#133ClassicOldSong wants to merge 4 commits intoAndyLevesque:mainfrom
ClassicOldSong wants to merge 4 commits intoAndyLevesque:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves chamfer/screw/connector interaction and adds an optional backside screw-head cutout.
What changed
Backside_Screw_HoleBackside_Screw_Head_Diameter_ShrinkBorder OnlyNon-Border OnlyEverywhere,Border Only, andNon-Border Onlyrespect the existing corner chamfer checkboxes (Chamfer_Top_Left,Chamfer_Top_Right,Chamfer_Bottom_Left,Chamfer_Bottom_Right) for the outer corners.Why
The previous logic was too coarse in a few places:
Cornersmode, while broader chamfer modes could still generate outer-corner chamfers even when a specific corner was disabledThis PR makes those interactions more local and predictable. Also, with backside screw hole enabled, we can use the more pretty top faces of stacked prints instead of being forced to use the hanged over face.
Behavior after this change
Cornersstill behaves as before, using only the selected outer cornersEverywherechamfers all valid positions except:Border Onlychamfers only border positions, while still respecting:Non-Border Onlychamfers only interior positions, while still respecting screw-hole positions