Fix Lite preview CGAL error and remove Full-path adhesive warning#132
Open
hazeledmands wants to merge 1 commit intoAndyLevesque:mainfrom
Open
Fix Lite preview CGAL error and remove Full-path adhesive warning#132hazeledmands wants to merge 1 commit intoAndyLevesque:mainfrom
hazeledmands wants to merge 1 commit intoAndyLevesque:mainfrom
Conversation
Replace the Lite screw-hole subtraction helper with an explicit unioned cutout shape so OpenSCAD preview no longer reports a non-closed mesh/CGAL conversion error. Also remove the unsupported Add_Adhesive_Base named argument from the Full single-tile path to eliminate the preview warning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two small OpenSCAD issues in
openGrid.scad.The given mesh is not closed! Unable to convert to CGAL_Nef_Polyhedron.) when screw mounting is enabled by replacing the chained attached screw subtraction solids with one explicit unioned cutout shape.Add_Adhesive_Basenamed argument from the Full single-tile path. Adhesive backing is a Lite-only feature, and this stray argument produced a warning in the Full preview path.Repro:
openscad --preview=throwntogether -o /tmp/preview.png openGrid.scadValidation:
openscad -o /tmp/openGrid.stl openGrid.scad.History note: