Skip to content

ci: upgrade GitHub Actions to Node 24–compatible versions#145

Merged
AmintaCCCP merged 3 commits into
mainfrom
fix/node-24-actions-deprecation
May 13, 2026
Merged

ci: upgrade GitHub Actions to Node 24–compatible versions#145
AmintaCCCP merged 3 commits into
mainfrom
fix/node-24-actions-deprecation

Conversation

@AmintaCCCP
Copy link
Copy Markdown
Owner

@AmintaCCCP AmintaCCCP commented May 13, 2026

变更内容

升级 CI workflow 中的 GitHub Actions 版本,解决 Node.js 20 弃用警告:

  • actions/checkout@v4@v5
  • actions/setup-node@v4@v5
  • actions/upload-artifact@v4@v5(3处)
  • actions/download-artifact@v4@v5

背景

GitHub Actions runner 将于 2026年6月2日 默认使用 Node.js 24 运行 JavaScript actions,2026年9月16日 移除 Node.js 20 支持。v5 版本的 actions 已适配 Node.js 24。

参考:https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/

Summary by CodeRabbit

  • Chores
    • Updated CI build workflow: refreshed action versions, upgraded Node runtime to v24, and standardized artifact upload/download across platforms for build and release jobs.
  • Note
    • No user-facing changes; purely maintenance to build infrastructure. Build and release steps remain functionally unchanged.

Review Change Stack

- actions/checkout@v4 → v5
- actions/setup-node@v4 → v5
- actions/upload-artifact@v4 → v5
- actions/download-artifact@v4 → v5

Resolves Node.js 20 deprecation warning. v5 actions use Node.js 24 runtime.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 13, 2026

📝 Walkthrough

Walkthrough

The build-desktop workflow updates GitHub Actions: actions/checkout@v6, actions/setup-node@v6 (Node 22 → 24), actions/upload-artifact@v7 in build jobs, and actions/download-artifact@v8 in the release job.

Changes

Workflow Actions Upgrade

Layer / File(s) Summary
Setup actions upgrade
.github/workflows/build-desktop.yml
actions/checkout and actions/setup-node upgraded to @v6; Node version changed from 22 to 24.
Build artifact upload upgrades
.github/workflows/build-desktop.yml
Windows, macOS, and Linux artifact upload steps updated from actions/upload-artifact@v4 to @v7.
Release artifact download upgrade
.github/workflows/build-desktop.yml
Release job artifact download updated from actions/download-artifact@v4 to @v8.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰
I nibbled YAML lines at dawn's soft glow,
Bumped Node to twenty-four and watched it grow,
Uploads now sail on v7 waves,
Downloads fetch with v8-bright braves,
A joyful rabbit hops, "CI, let's go!"

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately summarizes the main change: upgrading GitHub Actions to versions compatible with Node.js 24, which matches the primary objective of the pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/node-24-actions-deprecation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/build-desktop.yml:
- Line 23: The workflow upgrade to actions/checkout@v5 (and
actions/setup-node@v5) requires runner v2.327.1+ and may change caching
behavior; update your CI environment to use a runner version >= v2.327.1,
confirm or pin the runner in the workflow, and verify caching for setup-node by
either removing the explicit cache: 'npm' or confirming package.json has a
packageManager field so the new automatic caching behaves as expected; reference
the actions used (actions/checkout@v5, actions/setup-node@v5), the required
runner version (v2.327.1), the packageManager field in package.json, and the
explicit cache: 'npm' setting when making these changes.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e41d30d3-e610-4d39-a23d-0da2de55a80a

📥 Commits

Reviewing files that changed from the base of the PR and between b5a3593 and ded7b80.

📒 Files selected for processing (1)
  • .github/workflows/build-desktop.yml

Comment thread .github/workflows/build-desktop.yml Outdated
- actions/checkout@v5 → @v6
- actions/setup-node@v5 → @v6
- actions/upload-artifact@v5 → @v7
- actions/download-artifact@v5 → @v8

v5 actions still triggered Node.js 20 deprecation warnings.
Latest versions fully support Node.js 24 runtime.
@AmintaCCCP
Copy link
Copy Markdown
Owner Author

已修复 CodeRabbit 审计问题

Actions 版本升级到最新稳定版(v5 仍然触发 Node.js 20 警告):

  • actions/checkout@v5@v6
  • actions/setup-node@v5@v6
  • actions/upload-artifact@v5@v7
  • actions/download-artifact@v5@v8

Node.js 版本node-version'22' 更新到 '24'

其他说明

  • Runner 使用 *-latest 标签,GitHub 已自动更新到 v2.327.1+
  • package.jsonpackageManager 字段,cache: 'npm' 设置不受影响

@AmintaCCCP AmintaCCCP changed the title fix: upgrade GitHub Actions to v5 (Node.js 24 compatible) ci: upgrade GitHub Actions to Node 24–compatible versions May 13, 2026
@AmintaCCCP AmintaCCCP merged commit fee0908 into main May 13, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant