ci: upgrade GitHub Actions to Node 24–compatible versions#145
Conversation
- actions/checkout@v4 → v5 - actions/setup-node@v4 → v5 - actions/upload-artifact@v4 → v5 - actions/download-artifact@v4 → v5 Resolves Node.js 20 deprecation warning. v5 actions use Node.js 24 runtime.
📝 WalkthroughWalkthroughThe build-desktop workflow updates GitHub Actions: ChangesWorkflow Actions Upgrade
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/build-desktop.yml:
- Line 23: The workflow upgrade to actions/checkout@v5 (and
actions/setup-node@v5) requires runner v2.327.1+ and may change caching
behavior; update your CI environment to use a runner version >= v2.327.1,
confirm or pin the runner in the workflow, and verify caching for setup-node by
either removing the explicit cache: 'npm' or confirming package.json has a
packageManager field so the new automatic caching behaves as expected; reference
the actions used (actions/checkout@v5, actions/setup-node@v5), the required
runner version (v2.327.1), the packageManager field in package.json, and the
explicit cache: 'npm' setting when making these changes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: e41d30d3-e610-4d39-a23d-0da2de55a80a
📒 Files selected for processing (1)
.github/workflows/build-desktop.yml
已修复 CodeRabbit 审计问题Actions 版本升级到最新稳定版(v5 仍然触发 Node.js 20 警告):
Node.js 版本: 其他说明:
|
变更内容
升级 CI workflow 中的 GitHub Actions 版本,解决 Node.js 20 弃用警告:
actions/checkout@v4→@v5actions/setup-node@v4→@v5actions/upload-artifact@v4→@v5(3处)actions/download-artifact@v4→@v5背景
GitHub Actions runner 将于 2026年6月2日 默认使用 Node.js 24 运行 JavaScript actions,2026年9月16日 移除 Node.js 20 支持。v5 版本的 actions 已适配 Node.js 24。
Summary by CodeRabbit