Conversation
Develop config
Develop config
- Added an 'install' target that runs `go mod tidy` and fails if `go.sum` is not up-to-date. - Modified the 'test' target to use gotestsum for prettier test output, installing it automatically if not present. - Added a 'tree' target that checks for the `tree` command, attempts to install it on Linux/macOS if missing, and then displays the directory structure. - Updated CI workflows in .github/workflows/ci.yml: - Added a step to check go.sum consistency before building. - Maintained build, test, and coverage upload steps with improved formatting and consistency.
…gnoring any config file besides default for now
- Introduced a global `Verbose` flag in `config.go` to manage debug output. - Registered `--verbose` (`-v`) flag in `main.go` for user control. - Modified `Load()` in `config.go` to conditionally display `PrintNonEmptyFields()` output when `Verbose` is enabled. - Updated CLI tests in `main_test.go` to validate proper handling of CLI arguments. - Improved `TestCLIOverrides` to dynamically verify CLI argument overrides. - Standardized flag registration and execution flow for better maintainability. - Ensured verbose output is globally accessible without needing to pass it through function calls. This change improves debugging by allowing users to toggle detailed output while keeping default behavior concise.
feat: Add verbose flag (-v, --verbose) for enhanced system messages
Load - 100% OverrideWithCLI - 72%
Post-process the generated coverage profile to remove entries for `cmd/scrapeycli/main.go`, which are not intended to be unit tested. This change updates the Makefile's test target to filter out these lines before generating the HTML report, and also applies the same filtering in the CI workflow. This ensures that overall coverage is not skewed by the main package.
Develop configtests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full code coverage, and basic CLI output working.