Skip to content

fix(firmware/rmcs_board): Disable CAN automatic retransmission#53

Merged
qzhhhi merged 1 commit intomainfrom
dev/disable-retran
May 6, 2026
Merged

fix(firmware/rmcs_board): Disable CAN automatic retransmission#53
qzhhhi merged 1 commit intomainfrom
dev/disable-retran

Conversation

@qzhhhi
Copy link
Copy Markdown
Member

@qzhhhi qzhhhi commented May 6, 2026

Align rmcs_board CAN behavior with c_board by disabling hardware automatic retransmission.

摘要

本PR禁用了rmcs_board固件中CAN控制器的硬件自动重传功能,使其行为与c_board保持一致。

变更详情

文件: firmware/rmcs_board/app/src/can/can.hpp

Can构造函数中的MCAN配置初始化处新增配置项:

  • 添加 config.disable_auto_retransmission = true; 以禁用CAN自动重传功能

这是唯一的代码变更,其余逻辑保持不变。

影响范围

  • 仅影响rmcs_board的CAN驱动模块
  • 无公共API签名变更
  • 代码审查难度:中等

Align rmcs_board CAN behavior with c_board by disabling hardware automatic retransmission.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8c743a5f-37d5-4dca-bb74-9b9a3c8d2507

📥 Commits

Reviewing files that changed from the base of the PR and between 4106fe6 and 5c95386.

📒 Files selected for processing (1)
  • firmware/rmcs_board/app/src/can/can.hpp

Walkthrough

在CAN驱动配置中添加了一行代码,通过设置 config.disable_auto_retransmission = true; 来禁用MCAN的自动重传功能,无其他逻辑变更。

Changes

CAN驱动配置调整

层级 / 文件 摘要
驱动配置
firmware/rmcs_board/app/src/can/can.hpp
在Can构造函数的MCAN配置中添加 config.disable_auto_retransmission = true; 来禁用自动重传。

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 一行代码改梦想,
CAN总线不再张狂,
重传禁用显聪慧,
控制器心满意香。
✨ 兔子拍手叫欢畅!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed PR标题清晰准确地反映了主要变更内容,即禁用CAN自动重传功能,与文件修改和PR目标完全一致。
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev/disable-retran

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@qzhhhi
Copy link
Copy Markdown
Member Author

qzhhhi commented May 6, 2026

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 6, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@qzhhhi qzhhhi merged commit 3f5a34d into main May 6, 2026
5 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in RMCS Slave SDK May 6, 2026
@qzhhhi qzhhhi deleted the dev/disable-retran branch May 6, 2026 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant