Delegate bulk create/update to ryx_core#44
Merged
Conversation
Switch bulk operations to use the ryx_core Rust bindings: import ryx_core in bulk.py and call _core.bulk_insert in bulk_create (sending rows, requesting returning IDs) and _core.bulk_update in bulk_update (passing table, pk column, per-column values and pk list). Remove Python-side SQL generation and execution for updates, simplify value collection and PK assignment logic (handle DB-specific return formats). Also tidy imports and avoid name shadowing in Manager.bulk_update by aliasing the imported function, and tighten QuerySet.__init__ model typing to Model. These changes move heavy lifting to native code for performance and lower FFI overhead.
Einswilli
added a commit
to Einswilli/Ryx
that referenced
this pull request
May 9, 2026
Switch bulk operations to use the ryx_core Rust bindings: import ryx_core in bulk.py and call _core.bulk_insert in bulk_create (sending rows, requesting returning IDs) and _core.bulk_update in bulk_update (passing table, pk column, per-column values and pk list). Remove Python-side SQL generation and execution for updates, simplify value collection and PK assignment logic (handle DB-specific return formats). Also tidy imports and avoid name shadowing in Manager.bulk_update by aliasing the imported function, and tighten QuerySet.__init__ model typing to Model. These changes move heavy lifting to native code for performance and lower FFI overhead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch bulk operations to use the ryx_core Rust bindings: import ryx_core in bulk.py and call _core.bulk_insert in bulk_create (sending rows, requesting returning IDs) and _core.bulk_update in bulk_update (passing table, pk column, per-column values and pk list). Remove Python-side SQL generation and execution for updates, simplify value collection and PK assignment logic (handle DB-specific return formats). Also tidy imports and avoid name shadowing in Manager.bulk_update by aliasing the imported function, and tighten QuerySet.init model typing to Model. These changes move heavy lifting to native code for performance and lower FFI overhead.