Refactor and enhance Disassembler with tests and error handling#8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing and Reliability Improvements:
src/mem.rs,src/alloc.rs,src/disasm.rs, andsrc/threads.rs, respectively. These tests verify correct memory permissions, allocation behavior, instruction relocation, and thread enumeration, improving reliability and maintainability.Instruction Relocation Enhancements:
Disassembler::relocatemethod to return a newRelocationMappingstruct, which includes written length and instruction offset mappings. This enables more precise tracking and debugging of relocated instructions.src/transaction.rsto store redirect maps inInlineData, allowing hooks to retain instruction offset information for better gateway and trampoline management.API and Module Visibility Adjustments:
mod) insrc/lib.rs, and updated public exports to expose only relevant API functions and types, clarifying the library's external interface. Also added a compile-time error for non-Windows platforms.Minor Cleanups:
is_relativemethod fromDisassembler, as its functionality is now covered by improved relocation logic.