Skip to content

[PWGLF] Fix: Revert to struct name 'tofSpectra' for script compatibility#15183

Closed
tonmoySh wants to merge 2 commits intoAliceO2Group:masterfrom
tonmoySh:fix-tof-struct-compatibility
Closed

[PWGLF] Fix: Revert to struct name 'tofSpectra' for script compatibility#15183
tonmoySh wants to merge 2 commits intoAliceO2Group:masterfrom
tonmoySh:fix-tof-struct-compatibility

Conversation

@tonmoySh
Copy link
Contributor

This PR reverts the struct name to tofSpectra. While this intentionally triggers a naming convention warning, it is required to maintain the directory structure in AnalysisResults.root for backward compatibility with existing post-analysis macros.

@github-actions github-actions bot added the pwglf label Feb 26, 2026
@github-actions github-actions bot changed the title Fix: Revert to struct name 'tofSpectra' for script compatibility [PWGLF] Fix: Revert to struct name 'tofSpectra' for script compatibility Feb 26, 2026
@vkucera
Copy link
Collaborator

vkucera commented Feb 26, 2026

The PR title and description have nothing to do with the PR content.

@tonmoySh
Copy link
Contributor Author

The PR title and description have nothing to do with the PR content.

Apologies for the unrelated changes in this PR. The branch history became messy because it was not properly rebased leading to conflicts and an inaccurate diff. I will close this PR now and open a fresh, clean one that specifically addresses the tofSpectra name revert. Thank you for the feedback.

@vkucera
Copy link
Collaborator

vkucera commented Feb 27, 2026

The PR title and description have nothing to do with the PR content.

Apologies for the unrelated changes in this PR. The branch history became messy because it was not properly rebased leading to conflicts and an inaccurate diff. I will close this PR now and open a fresh, clean one that specifically addresses the tofSpectra name revert. Thank you for the feedback.

Next time please do not open another PR but update the current one. Duplicating PRs wastes compilation resources.

@tonmoySh
Copy link
Contributor Author

The PR title and description have nothing to do with the PR content.

Apologies for the unrelated changes in this PR. The branch history became messy because it was not properly rebased leading to conflicts and an inaccurate diff. I will close this PR now and open a fresh, clean one that specifically addresses the tofSpectra name revert. Thank you for the feedback.

Next time please do not open another PR but update the current one. Duplicating PRs wastes compilation resources.

Thank you very much for the feedback. I understand and will definitely follow it from the next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants