[PWGEM] Add optional PCM material-budget weights in PCMPCM#15139
Open
yelmardb wants to merge 3 commits intoAliceO2Group:masterfrom
Open
[PWGEM] Add optional PCM material-budget weights in PCMPCM#15139yelmardb wants to merge 3 commits intoAliceO2Group:masterfrom
yelmardb wants to merge 3 commits intoAliceO2Group:masterfrom
Conversation
Add a V0 photon material-budget weight table (Omega MB weights) and join it in the PCMPCM pi0/eta workflow. The weights are applied only when the joined column is available, using compile-time guarded access. Introduce a configurable switch (runWithMBWeights) in MaterialBudgetWeights: - false: no CCDB query, write weight=1 - true: require CCDB histogram and abort if missing
yelmardb
requested review from
alibuild,
dsekihat,
jokonig,
m-c-danisch,
mhemmer-cern,
mikesas,
novitzky and
rbailhac
as code owners
github-actions
bot
changed the title
yelmardb
force-pushed
the
yelmard-pcmpcm-omega-mb-weights
branch
2 times, most recently
from
1a5015f to
af257e1
Compare
yelmardb
force-pushed
the
yelmard-pcmpcm-omega-mb-weights
branch
from
af257e1 to
9476160
Compare
mhemmer-cern
requested changes
Feb 24, 2026
Comment on lines
-229
to
+234
| o2::framework::PresliceOptional<o2::soa::Filtered<o2::soa::Join<o2::aod::V0PhotonsKF, o2::aod::V0KFEMEventIds, o2::aod::V0PhotonsKFPrefilterBitDerived>>> perCollision_pcm = o2::aod::v0photonkf::emphotoneventId; | ||
| o2::framework::PresliceOptional<o2::soa::Join<o2::aod::EmEmcClusters, o2::aod::EMCEMEventIds>> perCollision_emc = o2::aod::emccluster::emphotoneventId; | ||
| o2::framework::PresliceOptional<o2::soa::Join<o2::aod::PHOSClusters, o2::aod::PHOSEMEventIds>> perCollision_phos = o2::aod::phoscluster::emphotoneventId; | ||
| o2::framework::PresliceOptional<o2::soa::Filtered<o2::soa::Join<o2::aod::EMPrimaryElectronsFromDalitz, o2::aod::EMPrimaryElectronDaEMEventIds, o2::aod::EMPrimaryElectronsPrefilterBitDerived>>> perCollision_electron = o2::aod::emprimaryelectronda::emphotoneventId; | ||
|
|
||
| o2::framework::PresliceOptional< | ||
| o2::soa::Filtered<o2::soa::Join<o2::aod::V0PhotonsKF, o2::aod::V0KFEMEventIds, o2::aod::V0PhotonsKFPrefilterBitDerived, o2::aod::V0PhotonOmegaMBWeights>>> | ||
| perCollision_pcm = o2::aod::v0photonkf::emeventId; | ||
| o2::framework::PresliceOptional<o2::soa::Join<o2::aod::EmEmcClusters, o2::aod::EMCEMEventIds>> perCollision_emc = o2::aod::emccluster::emeventId; | ||
| o2::framework::PresliceOptional<o2::soa::Join<o2::aod::PHOSClusters, o2::aod::PHOSEMEventIds>> perCollision_phos = o2::aod::phoscluster::emeventId; | ||
| o2::framework::PresliceOptional<o2::soa::Filtered<o2::soa::Join<o2::aod::EMPrimaryElectronsFromDalitz, o2::aod::EMPrimaryElectronEMEventIds, o2::aod::EMPrimaryElectronsPrefilterBitDerived>>> perCollision_electron = o2::aod::emprimaryelectron::emeventId; |
Collaborator
There was a problem hiding this comment.
Please make sure you are using the new emphotoneventId
Comment on lines
+85
to
+95
| void process(MyV0PhotonMB const& v0) | ||
| { | ||
| if (!runWithMBWeights) { | ||
| omegaMBWeight(1.f); | ||
| return; | ||
| } | ||
|
|
||
| omegaMBWeight(computeMBWeight(v0.v0radius())); | ||
| } | ||
| }; | ||
|
|
Collaborator
There was a problem hiding this comment.
Having a dummyProcess function which fills the weights with 1 is needed, since the weights are now needed for all MC PCM Photon analysis technically.
Comment on lines
227
to
-232
| // Preslices and partitions | ||
| o2::framework::SliceCache cache; | ||
| o2::framework::PresliceOptional<o2::soa::Filtered<o2::soa::Join<o2::aod::V0PhotonsKF, o2::aod::V0KFEMEventIds, o2::aod::V0PhotonsKFPrefilterBitDerived>>> perCollision_pcm = o2::aod::v0photonkf::emphotoneventId; | ||
| o2::framework::PresliceOptional<o2::soa::Join<o2::aod::EmEmcClusters, o2::aod::EMCEMEventIds>> perCollision_emc = o2::aod::emccluster::emphotoneventId; | ||
| o2::framework::PresliceOptional<o2::soa::Join<o2::aod::PHOSClusters, o2::aod::PHOSEMEventIds>> perCollision_phos = o2::aod::phoscluster::emphotoneventId; | ||
| o2::framework::PresliceOptional<o2::soa::Filtered<o2::soa::Join<o2::aod::EMPrimaryElectronsFromDalitz, o2::aod::EMPrimaryElectronDaEMEventIds, o2::aod::EMPrimaryElectronsPrefilterBitDerived>>> perCollision_electron = o2::aod::emprimaryelectronda::emphotoneventId; |
Collaborator
There was a problem hiding this comment.
Wrong header, the weights should be used in MC not in data
Comment on lines
-29
to
+30
| using MyV0Photons = o2::soa::Filtered<o2::soa::Join<o2::aod::V0PhotonsKF, o2::aod::V0KFEMEventIds, o2::aod::V0PhotonsKFPrefilterBitDerived>>; | ||
| using MyV0Photons = o2::soa::Filtered<o2::soa::Join<o2::aod::V0PhotonsKF, o2::aod::V0KFEMEventIds, o2::aod::V0PhotonsKFPrefilterBitDerived, o2::aod::V0PhotonOmegaMBWeights>>; |
Collaborator
There was a problem hiding this comment.
Wrong .cxx, this should be added in MC not in data.
Also it would be good to add this to PCMDalitzee as well in one go.
|
|
||
| Configurable<std::string> ccdbUrl{"ccdbUrl", "http://ccdb-test.cern.ch:8080", "CCDB url"}; | ||
| Configurable<std::string> mbWeightsPath{"mbWeightsPath", "Users/y/yelmard/MaterialBudget/OmegaMBWeights", "Path of the mb weights"}; | ||
| Configurable<bool> runWithMBWeights{"runWithMBWeights", false, "Run task using material-budget weights for PCM photons"}; |
Collaborator
There was a problem hiding this comment.
runWithMBWeights right now on false just results in an Fata error which is not caught and results in a crash.
I suggest to remove this configurable. Instead see comment below the addition of a dummy process function and process switches.
You can then use
if (doprocessName){
...
}inside the init function to only load the histogram if the non dummy process function is used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a V0 photon material-budget weight table (Omega MB weights) and join it in the PCMPCM pi0/eta workflow. The weights are applied only when the joined column is available, using compile-time guarded access.
Introduce a configurable switch (runWithMBWeights) in MaterialBudgetWeights: