[PWGEM] PhotonMeson: Fix bug in EMNonLin#15137
Open
mhemmer-cern wants to merge 1 commit intoAliceO2Group:masterfrom
Open
[PWGEM] PhotonMeson: Fix bug in EMNonLin#15137mhemmer-cern wants to merge 1 commit intoAliceO2Group:masterfrom
mhemmer-cern wants to merge 1 commit intoAliceO2Group:masterfrom
Conversation
- Fixed a bug where for higher iterations of the NonLin correction the input for iteration i was not the input value * scale_(i-1) but the unscaled input value - Changed the formluar of the NonLin from (1 + par0/x + par1/x^2) / (1 + par2/x) to (x + par0 +par1/x) / (x + par2) which is mathmatecially the same, however, it is a lot more stable since there is no 1/x^2 anymore. - Optimized the `setParams` calling inside `nonLinProducer.cxx` where it now should only be called if the collision and hence the centrality changes. Before this it was called for each photon!
mhemmer-cern
requested review from
alibuild,
dsekihat,
jokonig,
m-c-danisch,
mikesas,
novitzky and
rbailhac
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setParamscalling insidenonLinProducer.cxxwhere it now should only be called if the collision and hence the centrality changes. Before this it was called for each photon!