[PWGJE] Jet substructure SoftDrop#14916
[PWGJE] Jet substructure SoftDrop#14916louisemillot wants to merge 8 commits intoAliceO2Group:masterfrom
Conversation
louisemillot
requested review from
alibuild,
fjonasALICE,
maoyx,
mfasDa,
mhemmer-cern,
nzardosh and
raymondEhlers
as code owners
github-actions
bot
changed the title
|
Hi @louisemillot , thanks for your PR. Unfortunately I think you need to change the structure of your task. The tables in jetSubstructure.h are not meant for common analyses, they are meant for my own analyses and I would like to keep them independent so that I can change them freely as my analysis progresses. Instead you should look to develop your own tables for this analysis and replace them in your task. The only tables that can be used are the SPs tables, since they are core tables that can then be given to the matching tasks and avoids you having to write the matching from scratch. Therefore you need to make two tasks. One to fill the SP tables and your own tables, and one to store the output after the matching. |
nzardosh
left a comment
nzardosh
left a comment
There was a problem hiding this comment.
I have left a few comments but the task could do witha careful chck once you have tidied it up. Just to point out, my previous comment did not suggest that you change from tables to histograms, but that instead you make your own tables for this analysis (other than the common ones used for the subjet matching)
| PROCESS_SWITCH(JetSubstructureSoftDrop, processCollisionsFromData, "collisions from Data", false); | ||
|
|
||
| void processCollisionsFromMc(soa::Filtered<soa::Join<aod::JetCollisions, aod::JMcCollisionLbs>>::iterator const& collision, | ||
| soa::Join<aod::JetMcCollisions, aod::JMcCollisionPIs> const&, |
There was a problem hiding this comment.
why do you add the PI tables? You wont be able to run on derived data with these. Please only include tables you actually access
|
|
||
| void processCollisionsFromMcWeighted(soa::Join<aod::JetCollisions, aod::JMcCollisionLbs>::iterator const& collision, | ||
| soa::Join<aod::JetMcCollisions, aod::JMcCollisionPIs> const&, | ||
| soa::Join<aod::McCollisions, aod::HepMCXSections> const&) |
There was a problem hiding this comment.
why do you include these tables? the pThard info is contained in the JMcCollisions already
| } | ||
| auto z = parentSubJet2.perp() / (parentSubJet1.perp() + parentSubJet2.perp()); | ||
| auto theta = parentSubJet1.delta_R(parentSubJet2); | ||
| energyMotherVec.push_back(daughterSubJet.e()); |
There was a problem hiding this comment.
why are you filling these vectors since you dont then use them?
|
|
||
| fastjetutilities::fillTracks(jetConstituent, jetConstituents, jetConstituent.globalIndex()); | ||
| } | ||
| jetReclustering<false, isSubtracted>(jet, weight); |
There was a problem hiding this comment.
also how does this compile since you are returning a tuple here but not assigning it?
| } | ||
| PROCESS_SWITCH(JetSubstructureSoftDrop, processChargedJetsMCD, "charged jet MCD substructure weighted", false); | ||
|
|
||
| void processChargedJetsMCDWeighted(soa::Filtered<aod::JetCollisionsMCD>::iterator const& collision, |
There was a problem hiding this comment.
why do you have separate weighted and non weighted MC process fucntions?
| ChargedMCDMatchedJets const&, | ||
| aod::JetTracksSub const& tracks) | ||
| { | ||
| if (!jetderiveddatautilities::selectCollision(collision, eventSelectionBits, skipMBGapEvents)) { |
There was a problem hiding this comment.
all of these checks and the ones below on centrality and occupancy could go in a function so that they are not always repeated
| PROCESS_SWITCH(JetSubstructureSoftDrop, processJetsMCDEventWiseMatchedMCPWeighted, "matched mcp and mcd jets eventwise weighted", false); | ||
|
|
||
| int totalMCDjets = 0; | ||
| void processNumberOfMCDJetsWeighted(o2::aod::ChargedMCDetectorLevelJets const& mcdjet) |
There was a problem hiding this comment.
what is this process function doing? there is no output
3 participants
Add detailed jet substructure analysis for data, MCD, and MCP