Integrate TRD extra data support in AOD production workflow#15108
Integrate TRD extra data support in AOD production workflow#15108KangkanGoswami wants to merge 9 commits intoAliceO2Group:devfrom
Conversation
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
sawenzel
left a comment
sawenzel
left a comment
There was a problem hiding this comment.
approving, for now, to start CI
shahor02
left a comment
shahor02
left a comment
There was a problem hiding this comment.
Please see some suggestions below.
| static int q0s[6] = {-1}, q1s[6] = {-1}, q2s[6] = {-1}; | ||
| static float q0sCor[6] = {-1}, q1sCor[6] = {-1}, q2sCor[6] = {-1}; | ||
| static float ttgls[6] = {-999}, tphis[6] = {-999}; |
| return; | ||
| } | ||
| const auto& trk = recoData.getTrack<o2::trd::TrackTRD>(contributorsGID[GIndex::Source::TRD]); | ||
| auto trkC = trk; |
There was a problem hiding this comment.
There is no reason to copy full track with cov.matrix and all TRD extras, it is enough to take TrackPar part only, i.e.
o2::tack::TrackPar trkC{trk};
Then, the trk is the global track refitted inward to its innermost point, i.e. it is likely defined at the ITS IB. The rotation / propagation from there to TRD is very imprecise and may fail at low pTs.
I would suggest to use the outer version of the ITS-TPC or TPC track, so the propagation is done from the X=250. So, it will be:
o2::tack::TrackPar trkC{ contributorsGID[GIndex::Source::ITSTPC].isIndexSet() ?
recoData.getTPCITSTrack(contributorsGID[GIndex::Source::ITSTPC]).getParamOut() :
recoData.getTPCTrack(contributorsGID[GIndex::Source::TPC]).getParamOut() };
| o2::framework::Produces<o2::aod::FDDsExtra> fddExtraCursor; | ||
| o2::framework::Produces<o2::aod::FV0AsExtra> fv0aExtraCursor; | ||
|
|
||
| if (mEnableFITextra) { |
There was a problem hiding this comment.
To be sure: why does the TRD PR implement the FIT extra filling?
This commit enables the workflow to process TRD-specific calibration and noise information, allowing for more accurate reconstruction and analysis of TRD signals in AOD production.
This commit enables the workflow to generate TRD-specific extra tables in the AOD, applying calibration and noise corrections to improve reconstruction fidelity for TRD tracks.
This change allows users to enable or disable TRD extra output at runtime via workflow configuration, integrating TRD processing into the AOD production workflow.
…isDataModel.h This update to AnalysisDataModel.h standardizes TRD-related naming and introduces a dedicated SOA table for TRD extra data, allowing calibrated and corrected TRD quantities to be stored within the AOD framework.
KangkanGoswami
force-pushed
the
trdAOD
branch
from
3f938a8 to
e52a85c
Compare
Please consider the following formatting changes to AliceO2Group#15108
shahor02
left a comment
shahor02
left a comment
There was a problem hiding this comment.
Conditionally approving to trigger CI
|
@shahor02 : Could you follow up until you are happy? We should squash everything into a single commit. It is fine from my side as long as the full-system test (and all other CI) is green. |
5 participants
This PR fixes the problems with #14734
This pull request adds TRD extra data support to the AOD production workflow, including calibrated tracklet handling, local gain and noise corrections, and a new TRDsExtra SOA table in AnalysisDataModel.h. The changes introduce an optional runtime flag (--enable-TRD-extra) to control TRD output and extend existing workflow templates and data structures to incorporate TRD-specific quantities for improved reconstruction and analysis.