Fix herb issues#3873
Draft
tvdeyen wants to merge 11 commits into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3873 +/- ##
=======================================
Coverage 98.09% 98.09%
=======================================
Files 325 325
Lines 8650 8652 +2
=======================================
+ Hits 8485 8487 +2
Misses 165 165 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
We do not even render it in the controller
Use an actual button for a button
The class was never added because the silent erb tag was not returning anything. It turns out we do not have css for it anyway.
This rule produces a lot of false positives
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Describe you pull request here...
Closes # (Remove if not related to any issue)
Notable changes (remove if none)
Explain any changes (maybe breaking?) that have been made.
Screenshots
Remove if no visual changes have been made.
Checklist