Open
Conversation
added 5 commits
December 15, 2023 22:40
Default to release 2.3.0 since 2.4.0 changes filenames and behavior significantly So the env var won't work for version 2.4.0+.
…ases, and choose version(s) with env vars
…cessfully support older ones
Collaborator
Author
|
I've taken out the specific version check. That was basically an artefact of the belief that we could specify a version... And that's not working. The tests break when we do. I can version-lock the archive file and the JS and it's not enough. Something else is using the latest version somehow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the branch I'm using successfully for Scarpe-Wasm. I could probably use something a lot simpler than this successfully...
A lot of the complexity is the naming convention changes that ruby-wasm 2.4.0+ made. So we could also make this a lot simpler by just not supporting 2.3.0 and before.