⚡ Bolt: [performance improvement] Optimize unique tracking in search fallback#425
⚡ Bolt: [performance improvement] Optimize unique tracking in search fallback#425AhmmedSamier wants to merge 1 commit intomasterfrom
Conversation
…mainingItems Replaced the dynamic O(N) Uint8Array allocation in searchRemainingItems with a static O(1) mapping of priorityScopes to type IDs. This eliminates significant array allocation overhead and looping setup, reducing GC pressure and drastically improving burst search performance for unmatched queries (Zzz baseline reduced from ~40ms to ~19ms). Co-authored-by: AhmmedSamier <17784876+AhmmedSamier@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
💡 What$O(1)$ constant-time lookup mapped via a static 256-byte array (
Replaced a dynamic
Uint8Arrayallocation (new Uint8Array(this.items.length)) inSearchEngine.searchRemainingItemswith anskipTypeId).🎯 Why
Inside a performance-critical fallback search pass, the original code instantiated a large array proportional to the entire workspace size (e.g. 50,000+ items) on every call to track which scopes to skip. This caused severe allocation overhead and Garbage Collection (GC) pauses, throttling the burst search.
📊 Impact
🔬 Measurement
Verify via the burst search benchmarks:
cd language-server && bun run benchmarks/search_burst.bench.ts.PR created automatically by Jules for task 12556550429143644537 started by @AhmmedSamier