Skip to content

🎨 Palette: Fix QuickPick stuck in loading state when clearing history #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AhmmedSamier merged 1 commit into from
May 12, 2026
Merged

🎨 Palette: Fix QuickPick stuck in loading state when clearing history #406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## 2024-05-24 - QuickPick busy state reset
**Learning:** For VS Code extension `QuickPick` elements, if an interaction (e.g. prompt rendering) is short-circuited or handles a terminal modal action (like a confirmation), `quickPick.busy = false` must be explicitly set before presenting the modal, otherwise it will remain visually stuck in the loading state from a previous search.
**Action:** Always verify `quickPick.busy` is cleanly reset before rendering standalone prompts or static confirm/cancel lists within the same UI instance.
2 changes: 2 additions & 0 deletions vscode-extension/src/search-provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,6 +510,8 @@ export class SearchProvider {
* Prompt for confirmation before clearing history
*/
private promptClearHistory(quickPick: vscode.QuickPick<SearchResultItem>): void {
quickPick.busy = false;

const confirmItem: SearchResultItem = {
label: 'Confirm Clear History',
detail: 'This cannot be undone',
Expand Down
Loading