⚡ Bolt: Fast tree-sitter node type lookups via Sets#399
Conversation
Replaced repeated RegExp `.test()` calls with static `Set.has()` checks in `TreeSitterParser` for determining AST node types, eliminating regex evaluation overhead in hot parsing loops. Co-authored-by: AhmmedSamier <17784876+AhmmedSamier@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📝 WalkthroughWalkthroughA performance optimization refactors node type classification logic to replace regex-based pattern matching with Set-based membership lookups, eliminating repeated regex compilations and test operations in traversal-heavy code paths. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
💡 What: Replaced regular expression
.test()matching with staticSet.has()lookups ingetSearchItemTypeandgetLanguageSpecificItemTypeinsidelanguage-server/src/core/tree-sitter-parser.ts.🎯 Why: Tree-sitter node types are evaluated heavily during file parsing. Executing regexes on every node causes unnecessary string evaluation overhead, whereas
Set.has()allows O(1) exact matching.📊 Impact: Expected to be ~3.4x faster for node type checks based on microbenchmarks, speeding up overall index parsing times.
🔬 Measurement: Verify by running indexer benchmarks or monitoring
language-servertest times.PR created automatically by Jules for task 16555545874892125358 started by @AhmmedSamier
Summary by CodeRabbit
Performance
Documentation