⚡ Bolt: Use manual array push instead of spread operator for search results

[AhmmedSamier]

💡 What: Replaced allResults.push(...providerResults); with a manual for loop pushing elements one by one.
🎯 Why: Using the array spread operator on unbounded or huge arrays risks exceeding the maximum call stack size limit in V8, causing crashes during high-volume queries or large workspace scans.
📊 Impact: Eliminates call stack exhaustion risk during burst searches or across multiple providers returning large datasets, improving reliability for edge cases.
🔬 Measurement: Can be verified by running the search test suite and verifying memory tests, or doing a burst search that returns > 100k items. No regressions are expected since it's a 1:1 behavioral translation.

---

PR created automatically by Jules for task 6362339077969321959 started by @AhmmedSamier

Summary by CodeRabbit

• Chores

  • Updated internal coding guidelines and documentation standards.

• Refactor

  • Optimized internal search result aggregation logic for consistency.

Note: This release contains internal improvements with no user-facing changes.

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

Warning

Rate limit exceeded

@AhmmedSamier has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 30 minutes and 28 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1a87f8e0-478d-491b-aef3-3bac8b2a1df2

📥 Commits

Reviewing files that changed from the base of the PR and between 7720b8e and de8909d.

📒 Files selected for processing (2)

• .jules/bolt.md
• language-server/src/core/search-engine.ts

📝 Walkthrough

Walkthrough

This PR adds a dated note to documentation discouraging manual array method unrolling as an anti-pattern, and refactors SearchEngine result aggregation to use an explicit index-based loop instead of spread operator syntax for performance optimization.

Changes

Cohort / File(s)	Summary
Documentation Update .jules/bolt.md	Added dated note (2026-04-10) explaining that manually unrolling array methods like .map() into for loops is an anti-pattern, as it harms readability and may trigger linting rules without consistent performance benefits. Recommends preferring .map() and other readable array methods.
Search Engine Aggregation Refactor language-server/src/core/search-engine.ts	Replaced spread operator aggregation (push(...array)) with explicit index-based loop when aggregating providerResults into allResults in executeProviderSearch.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• ⚡ Bolt: [O(N) Callback Removal] #356: Makes the same pattern change in search-engine.ts—replacing Array higher-order calls with explicit index-based loops to avoid callback/allocation overhead.
• ⚡ Bolt: [performance improvement] #326: Modifies search-engine.ts to replace higher-order/spread operations with explicit index-based loops for reducing allocations in hot search paths.
• ⚡ Bolt: optimize handleEmptyQuerySearch with single-pass filtering #333: Also modifies search-engine.ts to replace spread/push with explicit indexed loops for provider result aggregation and single-pass filtering.

Poem

🐰 Loop by loop, no spread in sight,
Explicit paths feel clean and right,
We whisper: .map() stays supreme,
Readability's the rabbit's dream! 🌟

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title mentions using manual array push instead of spread operator, which directly matches the main code change in search-engine.ts, but the emoji and broad framing mask the actual rationale (stack overflow mitigation). The primary change is a bug-fix optimization, not a minor performance tweak as the title suggests.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch jules-6362339077969321959-ccfb439c

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}