[Fix] Correct SNR calculation logic#437
Open
JMZ-kk wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where the measured SNR values did not match the design targets and varied inconsistently across different MIMO configurations.
Specifically, it addresses the incorrect scaling of noise generation regarding Array Gain (total received signal power scaling with users) and Pilot Sparsity (frequency-orthogonal mode).
Problem Description
Previously, the noise generation logic did not account for the signal power scaling inherent in different MIMO configurations. For example, in
files/config/examples/rp-sim-ul.json, a setting of"noise_level": 0.01(targeted for ~40 dB SNR) resulted in inconsistent actual SNRs:Root Causes identified:
Changes
We adjusted the noise generation to maintain a constant SNR regardless of the configuration: