Updated functionality for basic testing#6
Open
octo-youcef wants to merge 17 commits intoAgeOfLearning:mainfrom
Open
Updated functionality for basic testing#6octo-youcef wants to merge 17 commits intoAgeOfLearning:mainfrom
octo-youcef wants to merge 17 commits intoAgeOfLearning:mainfrom
Conversation
added 17 commits
May 27, 2022 09:13
Updated the app, and operations to resolve a number of issues, including - creating directories in the wrong locations - incorrect test mechanism (would always select 1 row) - incorrect model/seed selection - data dir instead of seed dir
Updated the app and batch templates to resolve the following - selecting batch number for all batches - no default batch number set - not providing a batch should raise an error
Contributor
|
Thanks again @octo-youcef , I will make sure this all works on our system, merge it and push to pypi. |
Author
|
Awesome. Note: There are still issues when running |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realise a lot of changes here were cosmetic and personal preferences. I had originally submitted a PR from my fork's main branch - I am happy to reset any of those cosmetic changes in this branch on request.