Dockerize project#12
Open
alexwh wants to merge 17 commits into
Open
Conversation
it's literally the same as just building the image
what in the fuck is the point of a package registry if you can't pull public images without authentication, github?
Contributor
Author
|
Should be good - you'll need to set DOCKER_USERNAME and DOCKER_PASSWORD in this project's secrets tab under settings to get pushes to Docker Hub. |
we can't map just a file in the container to a volume, it has to be a directory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made a Dockerfile to build this project in Docker. Not done yet, still need to look into GitHub Actions CI to automate builds.