fix: no-dead-urls false positives for mailto, anchor, and redirect URLs (DEVSITE-2405)#87
Merged
Merged
Conversation
…redirects - Add /^mailto:/ to skipUrlPatterns so email links are never checked - Add checkAnchor: false to stop anchor fragment verification in page HTML - Rename followRedirect → followRedirects (correct dead-or-alive option name) so HTTP→HTTPS redirects are followed instead of flagged Fixes #86 Co-authored-by: jiangy10 <jiangy10@users.noreply.github.com>
melissag-ensemble
requested changes
May 14, 2026
Contributor
Author
|
Resolved the commented content and updated test file with fragment test: AdobeDocs/adp-devsite-github-actions-test@501d641 |
melissag-ensemble
approved these changes
May 19, 2026
…redirects - Add /^mailto:/ to skipUrlPatterns so email links are never checked - Add checkAnchor: false to stop anchor fragment verification in page HTML - Rename followRedirect → followRedirects (correct dead-or-alive option name) so HTTP→HTTPS redirects are followed instead of flagged Fixes #86 Co-authored-by: jiangy10 <jiangy10@users.noreply.github.com>
…nto claude/issue-86-20260514-1915
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes false positives in the no-dead-urls linter for three URL patterns:
mailto:links are now skipped via a built-inskipUrlPatternsentrycheckAnchor: false)followRedirects: true, fixing the previously misspelledfollowRedirectoption)Closes #86
JIRA
DEVSITE-2405
Test
AdobeDocs/adp-devsite-github-actions-test@4961677
Before
After