Skip to content

AG-50852 Updated documentation for $removeparam rules in AdGuard#843

Open
maximtop wants to merge 1 commit intomasterfrom
fix/AG-50852
Open

AG-50852 Updated documentation for $removeparam rules in AdGuard#843
maximtop wants to merge 1 commit intomasterfrom
fix/AG-50852

Conversation

@maximtop
Copy link
Contributor

Should be merged after release v5.4

…r Chrome MV3 to explain redirect chaining mechanism
Copy link
Contributor

@windsurf-bot windsurf-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 To request another review, post a new comment with "/windsurf-review".

- Regular expressions, negation and allowlist rules are not supported.
- Generic rules are applied before specific rules, and redirection occurs only once. This may prevent subsequent or more specific redirects from applying.
- Group of similar `$removeparam` rules will be combined into one. Example:
- Each `$removeparam` rule with a named parameter gets its own declarative rule with a param-aware `urlFilter` (e.g. `^utm_source=`). Chrome DNR applies a redirect only once per navigation, so without this, only the highest-priority rule would fire and the rest would be skipped. The param-aware `urlFilter` makes each rule fire only when its target parameter is present, forming a redirect chain — one parameter stripped per hop — until all are removed. Chrome allows up to 20 hops per navigation, which is enough for real-world tracking URLs. These hops are invisible to users. Example:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation mentions that Chrome allows up to 20 hops per navigation for parameter removal. Could you add information about what happens if there are more than 20 parameters to remove? Would some parameters remain unprocessed?

@github-actions
Copy link

Preview was deployed to: https://pull-request-843.kb-adg.pages.dev/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant