Skip to content

fix(ci): unblock macOS dev-release prereqs #1231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ErikBjare merged 2 commits into from
Apr 1, 2026
Merged

fix(ci): unblock macOS dev-release prereqs #1231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d73c53
fix(ci): unblock macOS dev-release prereqs
TimeToBuildBob Apr 1, 2026
7d3994d
fix(ci): preserve entitlements under hardened runtime
TimeToBuildBob Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,12 @@ uninstall:
test:
@for module in $(TESTABLES); do \
echo "Running tests for $$module"; \
poetry run make -C $$module test || { echo "Error in $$module tests"; exit 2; }; \
done
if [ -f "$$module/pyproject.toml" ]; then \
(cd $$module && poetry run make test) || { echo "Error in $$module tests"; exit 2; }; \
else \
make -C $$module test || { echo "Error in $$module tests"; exit 2; }; \
fi; \
done

test-integration:
# TODO: Move "integration tests" to aw-client
Expand Down
5 changes: 4 additions & 1 deletion scripts/package/build_app_tauri.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,10 @@ echo "APPL????" > "dist/${APP_NAME}.app/Contents/PkgInfo"

if [ -n "$APPLE_PERSONALID" ]; then
echo "Signing app with identity: $APPLE_PERSONALID"
codesign --deep --force --sign "$APPLE_PERSONALID" "dist/${APP_NAME}.app"
# Hardened runtime is required for notarization prechecks on macOS.
# The Tauri bundle still embeds PyInstaller-built helpers from dist/activitywatch/,
# so keep the existing entitlements that those binaries need under hardened runtime.
codesign --deep --force --options runtime --entitlements scripts/package/entitlements.plist --sign "$APPLE_PERSONALID" "dist/${APP_NAME}.app"
echo "App signing complete."
else
echo "APPLE_PERSONALID not set. Skipping code signing."
Expand Down
Loading