Skip to content

update home dir to /public#2062

Merged
RohitKushvaha01 merged 1 commit into
Acode-Foundation:mainfrom
RohitKushvaha01:main
Apr 27, 2026
Merged

update home dir to /public#2062
RohitKushvaha01 merged 1 commit into
Acode-Foundation:mainfrom
RohitKushvaha01:main

Conversation

@RohitKushvaha01
Copy link
Copy Markdown
Member

No description provided.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 27, 2026

Greptile Summary

This PR aligns the HOME environment variable in the embedded initrc heredoc with the value already set at the top of init-alpine.sh, changing /home to /public. The fix resolves an inconsistency where the outer script advertised HOME=/public but the per-session initrc (which runs on every terminal start) still exported HOME=/home.

Confidence Score: 4/5

Safe to merge once the existence of /public inside the chroot is confirmed.

Single P2 finding — the change is logically correct (resolves a HOME inconsistency) but relies on /public being a real, writable directory inside the Alpine chroot; if it isn't, shell sessions degrade. No P0/P1 issues found.

src/plugins/terminal/scripts/init-alpine.sh — verify /public is always mounted/created before the terminal session starts.

Important Files Changed

Filename Overview
src/plugins/terminal/scripts/init-alpine.sh Changes HOME from /home to /public inside the embedded initrc heredoc, making it consistent with the top-level export on line 3; no guard ensures /public exists in the chroot.

Sequence Diagram

sequenceDiagram
    participant App as Acode App
    participant Script as init-alpine.sh
    participant RC as /initrc (heredoc)
    participant Shell as bash session

    App->>Script: launch terminal
    Script->>Script: export HOME=/public (line 3)
    Script->>RC: write initrc with HOME=/public (line 162, changed)
    Script->>Shell: bash --rcfile /initrc -i
    Shell->>RC: source initrc
    RC->>Shell: export HOME=/public
    RC->>Shell: source $HOME/.bashrc → /public/.bashrc
Loading

Reviews (1): Last reviewed commit: "Update init-alpine.sh" | Re-trigger Greptile

Comment thread src/plugins/terminal/scripts/init-alpine.sh
@RohitKushvaha01 RohitKushvaha01 merged commit 4035fe6 into Acode-Foundation:main Apr 27, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant