fix(euclid): restore div_saved on boot, refresh mute LED on scene load#523
Merged
Conversation
…load The clock division was saved correctly but never restored when the app booted — div_glob always initialized to the hardcoded default of 6, losing the user's preference across reloads. Scene-load already did this; only the initial boot path was missing it. Also refreshes the channel-1 button LED on scene load so it matches the loaded mute state immediately instead of waiting for the next button-press interaction to repaint it. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
chmanie
pushed a commit
that referenced
this pull request
May 16, 2026
…on scene load (#523) The clock division was saved correctly but never restored when the app booted — div_glob always initialized to the hardcoded default of 6, losing the user's preference across reloads. Scene-load already did this; only the initial boot path was missing it. Also refreshes the channel-1 button LED on scene load so it matches the loaded mute state immediately instead of waiting for the next button-press interaction to repaint it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
div_savedfrom storage. Previously, the user's clock division setting was saved correctly but never read back on app boot —div_globalways initialized to the hardcoded default (6 / 16th notes), so any custom division reverted on layout reload. The scene-load path already handled this; only the initial run() path was missing it.configurator/pnpm-workspace.yamland pinspackageManagerto pnpm 11.1.1 — required for the configurator CI step to install successfully under pnpm 11's new build-script approval policy.Test plan
🤖 Generated with Claude Code