ATL-64: Refactor TransactionTable to extract demo data#22
Open
bolty-from-atl-bitlab[bot] wants to merge 1 commit intomasterfrom
Open
ATL-64: Refactor TransactionTable to extract demo data#22bolty-from-atl-bitlab[bot] wants to merge 1 commit intomasterfrom
bolty-from-atl-bitlab[bot] wants to merge 1 commit intomasterfrom
Conversation
- Created fixtures/transactionTableData.ts with demo transactions, prisms, and contacts - Removed hardcoded demo data from TransactionTable component - Component now accepts data as props (transactions, prisms, contacts) - Added TransactionTable.stories.tsx with multiple story variants: - WithDemoData: Shows table with full demo dataset - Empty: Shows empty state - SingleTransaction: Minimal data test case - FewTransactions: Limited data for pagination testing - WithFavorites: Demonstrates favorite functionality - MixedStatuses: Shows all status types Fixes ATL-64
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR refactors the TransactionTable component to properly separate demo data from the component implementation.
What was done:
Created fixtures directory and data file
app/components/fixtures/transactionTableData.tsdemoTransactions,demoPrisms, anddemoContactsTransactioninterface for type reuseRefactored TransactionTable component
Transactiontype from fixturesCreated Storybook stories
TransactionTable.stories.tsxwith 6 story variants:Expected usage:
Testing:
Fixes ATL-64