fix(unity-bootstrap-theme): hero small CTA overflow at <768px (UDS-2171)#1688
Open
juanmitriatti wants to merge 1 commit intodevfrom
Open
fix(unity-bootstrap-theme): hero small CTA overflow at <768px (UDS-2171)#1688juanmitriatti wants to merge 1 commit intodevfrom
juanmitriatti wants to merge 1 commit intodevfrom
Conversation
Move .btn-row out of position:absolute (with hard-coded top:15rem) into grid-row:4 with position:relative, matching the existing tablet+ pattern. The container now expands naturally to contain the button instead of overflowing at viewports between mobile and the 768px breakpoint (reproduced at 764x921). Adds margin-top:1rem to give the requested breathing room between heading and button. Scoped to uds-hero-sm only.
Collaborator
|
Storybook deployed at https://unity-uds-staging.s3.us-west-2.amazonaws.com/pr-1688/index.html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Diff
```diff
@@ div.uds-hero-sm.has-btn-row .btn-row @@
align-self: flex-start;
flex-wrap: wrap;
```
3 lines added, 1 removed. `yarn css-lint` passes; full SCSS compiles cleanly.
Test plan
Tested in Chrome at multiple viewports (computed styles + visual screenshots):