Skip to content

UDS-1772: fix(component-header-footer): fix nav link doesn't close menu #1687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
scott-williams-az wants to merge 1 commit into
base: dev
Choose a base branch
from
+19 −5
Open

UDS-1772: fix(component-header-footer): fix nav link doesn't close menu #1687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ...component-header-footer/src/header/components/HeaderMain/NavbarContainer/NavItem/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@ const NavItem = ({ link, setItemOpened, itemOpened }) => {
// so we need to manually close the menu and trigger the onClick event
setMobileMenuOpen(false);
setItemOpened();
link.onClick?.(e);
return;
}
const { key } = e;
Expand Down Expand Up @@ -194,9 +195,14 @@ const NavItem = ({ link, setItemOpened, itemOpened }) => {
// Regardless of state or props mobile/desktop/hover/click
// if the item has a dropdown, we want to toggle it on Enter/Space
setItemOpened();
} else {
// Single page apps do not leave the page on link click,
// so we need to manually close the menu and trigger the onClick event
setMobileMenuOpen(false);
setItemOpened();
link.onClick?.(e);
}
dispatchGAEvent();
link.onClick?.(e);
}
if (key === "ArrowDown" || key === "ArrowRight") {
if (opened) {
Expand Down
16 changes: 12 additions & 4 deletions packages/component-header-footer/src/header/core/utils/data-mock.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,12 @@ const basicNavTree = [
text: "Sublink 2",
},
{
href: "https://www.asu.edu",
text: "Sublink 3",
onClick: () => {
console.log(
"onClick Callback - Single page app, onClick should close mobile menu and trigger GA event"
);
},
text: "Single Page App Click 3",
},
{
href: "https://www.asu.edu",
Expand Down Expand Up @@ -87,8 +91,12 @@ const basicNavTree = [
href: "#",
},
{
text: "Link option 4",
href: "#",
text: "Single Page App Click 4",
onClick: () => {
console.log(
"onClick Callback - Single page app, onClick should close (mobile/dropdown) menu and trigger GA event"
);
},
},
{
text: "Link option 5",
Expand Down