docs: update Theme Screen (Vintage) screenshot in README#776
docs: update Theme Screen (Vintage) screenshot in README#776Arunodoy18 wants to merge 1 commit intoAOSSIE-Org:masterfrom
Conversation
|
🎉 Welcome @Arunodoy18!
We appreciate your contribution! 🚀 |
📝 WalkthroughWalkthroughThe README.md documentation file was updated to replace an outdated image reference in a table row. Specifically, the "Upcoming Room Screen (Cream)" image for the Vintage column was changed from an external GitHub asset URL to a local image path for consistency and maintainability. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@README.md`:
- Line 91: The three <img> tags in the README row (the elements with src values
"https://github.com/user-attachments/assets/ba7da784-48a6-4512-a4c-9f12b8ad13c1",
"docs/store_listing/images/playstore_screenshots/8.png", and
"https://github.com/user-attachments/assets/a46c7da4-2df4-4c62-9e4c-9c92102339e9")
are missing alt attributes; add meaningful alt text for each image (e.g., brief
descriptions of the screenshot or graphic) by adding alt="..." to each <img> tag
so the row satisfies MD045 and improves accessibility.
| | Explore Story (Amber) | Theme Screen (Vintage) | Upcoming Room Screen (Cream) | | ||
| | :---------------------------------------------------------------------------------------------------------------------- | :---------------------------------------------------------------------------------------------------------------------- | :--------------------------------------------------------------------------------------------------------------------- | | ||
| | <img src="https://github.com/user-attachments/assets/ba7da784-48a6-4512-a4c8-9f12b8ad13c1" width="250" height="auto" /> | <img src="https://github.com/user-attachments/assets/ba9273f2-ceef-441d-8f94-4e0bc53b3e99" width="250" height="auto" /> | <img src="https://github.com/user-attachments/assets/a46c7da4-2df4-4c62-9e4c-9c92102339e9" width="250" height="auto"/> | | ||
| | <img src="https://github.com/user-attachments/assets/ba7da784-48a6-4512-a4c8-9f12b8ad13c1" width="250" height="auto" /> | <img src="docs/store_listing/images/playstore_screenshots/8.png" width="250" height="auto" /> | <img src="https://github.com/user-attachments/assets/a46c7da4-2df4-4c62-9e4c-9c92102339e9" width="250" height="auto"/> | |
There was a problem hiding this comment.
Add alt text to images in this row (accessibility/lint).
At Line 91, the <img> tags are missing alt attributes, which triggers MD045 and reduces accessibility for screen readers.
✅ Suggested patch
-| <img src="https://github.com/user-attachments/assets/ba7da784-48a6-4512-a4c8-9f12b8ad13c1" width="250" height="auto" /> | <img src="docs/store_listing/images/playstore_screenshots/8.png" width="250" height="auto" /> | <img src="https://github.com/user-attachments/assets/a46c7da4-2df4-4c62-9e4c-9c92102339e9" width="250" height="auto"/> |
+| <img src="https://github.com/user-attachments/assets/ba7da784-48a6-4512-a4c8-9f12b8ad13c1" alt="Explore Story screen in Amber theme" width="250" height="auto" /> | <img src="docs/store_listing/images/playstore_screenshots/8.png" alt="Theme screen in Vintage theme" width="250" height="auto" /> | <img src="https://github.com/user-attachments/assets/a46c7da4-2df4-4c62-9e4c-9c92102339e9" alt="Upcoming Room screen in Cream theme" width="250" height="auto" /> |📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| | <img src="https://github.com/user-attachments/assets/ba7da784-48a6-4512-a4c8-9f12b8ad13c1" width="250" height="auto" /> | <img src="docs/store_listing/images/playstore_screenshots/8.png" width="250" height="auto" /> | <img src="https://github.com/user-attachments/assets/a46c7da4-2df4-4c62-9e4c-9c92102339e9" width="250" height="auto"/> | | |
| | <img src="https://github.com/user-attachments/assets/ba7da784-48a6-4512-a4c8-9f12b8ad13c1" alt="Explore Story screen in Amber theme" width="250" height="auto" /> | <img src="docs/store_listing/images/playstore_screenshots/8.png" alt="Theme screen in Vintage theme" width="250" height="auto" /> | <img src="https://github.com/user-attachments/assets/a46c7da4-2df4-4c62-9e4c-9c92102339e9" alt="Upcoming Room screen in Cream theme" width="250" height="auto" /> | |
🧰 Tools
🪛 markdownlint-cli2 (0.21.0)
[warning] 91-91: Images should have alternate text (alt text)
(MD045, no-alt-text)
[warning] 91-91: Images should have alternate text (alt text)
(MD045, no-alt-text)
[warning] 91-91: Images should have alternate text (alt text)
(MD045, no-alt-text)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@README.md` at line 91, The three <img> tags in the README row (the elements
with src values
"https://github.com/user-attachments/assets/ba7da784-48a6-4512-a4c-9f12b8ad13c1",
"docs/store_listing/images/playstore_screenshots/8.png", and
"https://github.com/user-attachments/assets/a46c7da4-2df4-4c62-9e4c-9c92102339e9")
are missing alt attributes; add meaningful alt text for each image (e.g., brief
descriptions of the screenshot or graphic) by adding alt="..." to each <img> tag
so the row satisfies MD045 and improves accessibility.
Summary
Replaces the outdated Theme Screen (Vintage) screenshot in README.md with the updated version from the latest playstore screenshots.
Changes
Closes #775
Summary by CodeRabbit