Skip to content

Integ sp8 g feedback 05032026 #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akky16 wants to merge 2 commits into
base: integ_sp8
Choose a base branch
from
Open

Integ sp8 g feedback 05032026 #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea803bd
misc: amd-apml: Refine APML I3C messages for TSI
akky16 Mar 5, 2026
44c2a28
misc: amd-apml: Refine APML I3C messages for RMI
akky16 Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions drivers/misc/amd-apml/apml_sbtsi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,7 +487,8 @@ static int sbtsi_i3c_probe(struct i3c_device *i3cdev)
dev_info(dev, "SBTSI: PID: %llx\n", i3cdev->desc->info.pid);
if (!(I3C_PID_INSTANCE_ID(i3cdev->desc->info.pid) == 0 ||
i3cdev->desc->info.pid == 0x22400000001)) {
dev_info(dev, "SBTSI: Error PID: %llx\n", i3cdev->desc->info.pid);
dev_info(dev, "SBTSI: PID mismatch: 0x%llx not a TSI controller",
i3cdev->desc->info.pid);
return -ENXIO;
}

Expand All @@ -514,8 +515,8 @@ static int sbtsi_i3c_probe(struct i3c_device *i3cdev)
map_sbtsi_pid_to_static_addr(i3cdev, tsi_dev);
if (tsi_dev->dev_static_addr == 0)
{
dev_info(dev, "SBTSI: PID = 0x%llx, static address zero, skip the device\n",
i3cdev->desc->info.pid);
dev_err(dev, "SBTSI: PID = 0x%llx, static address zero, skip the device\n",
i3cdev->desc->info.pid);
return -ENXIO;
}

Expand Down
7 changes: 4 additions & 3 deletions drivers/misc/amd-apml/sbrmi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -682,7 +682,8 @@ static int sbrmi_i3c_probe(struct i3c_device *i3cdev)

if (!(I3C_PID_INSTANCE_ID(i3cdev->desc->info.pid) == 1 ||
i3cdev->desc->info.pid == 0x22400000002)) {
dev_info(dev, "SBRMI: PID Error: %llx\n", i3cdev->desc->info.pid);
dev_info(dev, "SBRMI: PID mismatch: 0x%llx not a RMI controller\n",
i3cdev->desc->info.pid);
return -ENXIO;
}

Expand All @@ -705,8 +706,8 @@ static int sbrmi_i3c_probe(struct i3c_device *i3cdev)
map_sbrmi_pid_to_static_addr(i3cdev, rmi_dev);
if (rmi_dev->dev_static_addr == 0)
{
dev_info(dev, "SBRMI: PID = 0x%llx, static address zero, skip the device\n",
i3cdev->desc->info.pid);
dev_err(dev, "SBRMI: PID = 0x%llx, static address zero, skip the device\n",
i3cdev->desc->info.pid);
}

hwmon_dev_name = devm_kasprintf(dev, GFP_KERNEL, "sbrmi_%s",
Expand Down