Preserve field value when transition validation fails#81
Open
regiscamimura wants to merge 1 commit into5monkeys:masterfrom
Open
Preserve field value when transition validation fails#81regiscamimura wants to merge 1 commit into5monkeys:masterfrom
regiscamimura wants to merge 1 commit into5monkeys:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #80
When an invalid transition is attempted, the field setter was updating the stored value before running validation. This meant that even though
InvalidStatusOperationErrorwas raised, the field already held the invalid value.Moved
validate_valid_transition()to run before the assignment so the field retains its previous value on failure.Added a test that confirms the field value is preserved after a rejected transition.