docs: adds info on extending PrismaClient type in readme#130
Open
docs: adds info on extending PrismaClient type in readme#130
Conversation
Pull Request Test Coverage Report for Build 11470422894Details
💛 - Coveralls |
franky47
requested changes
Oct 23, 2024
Member
There was a problem hiding this comment.
Thanks! Yes I think this might be a bit verbose for the initial setup phase, I'd rather have this code block focusing on showcasing the fieldEncryptionExtension function (too bad we can't highlight lines on GitHub).
suggestion: Maybe we could move the TS-specifics into a <details><summary> block, with a title of something like "Typing the extended client with TypeScript", what do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant Github Issue:
#129
I added this in the default integration snippet because the snippet already uses Typescript, and my experience tells me it's important. Please let me know if you'd like me to keep that block of code more minimal and I can create a separate section that talks about extending the PrismaClient type.
Thanks again for your hard work on this library!