Improve GenericTypeResolver API#466
Open
ggleyzer wants to merge 11 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An important part of the compiler type validation and runtime is resolution of generic/formal types. The GenericTypeResolver used to have two paths: one for resolving the FormalConstant and the other for resolving the generic type names, while the first one had a default implementation immediately turning the formal constant into its name. The problem with this approach was that some times unrelated formal constants of the same name would resolve the same way.
This change eliminates the name-based resolution in favor of the FormalConstant-based one.