Incompatible with Ember 2.0 and below

[Turbo87]

The registerDeprecationHandler() method does not exist in Ember 2.0 and below. Since the deprecation tracking setup is using the method unconditionally it will break the test even if the expectDeprecation() method is never used. This makes it impossible to use this addon in an ember-try scenario that targets an older Ember version.

[rwjblue]

@Turbo87 - IMHO, it seems fine to support only 2.0 and higher, however we could also just include the polyfill for 1.x support

[Turbo87]

for reference "the polyfill" is https://github.com/rwjblue/ember-debug-handlers-polyfill

[workmanw]

We chatted on Slack. I'm closing this in favor of adding a note to the readme about ember-debug-handlers-polyfill.

[Turbo87]

no, I'm closing this! 😁

[workmanw]

Hehe. I hit "Comment and close" and it said you had already closed, and no joke I said "Jinx" out loud. 😂

[Turbo87]

Unfortunately this seems to still be an issue independent from using the polyfill or not

not ok 1 Chrome 62.0 - Global error: Uncaught TypeError: _ember.default.Debug.registerWarnHandler is not a function at http://localhost:7357/assets/test-support.js, line 7468
    ---
        Log: |
            { type: 'error',
              text: 'Uncaught TypeError: _ember.default.Debug.registerWarnHandler is not a function at http://localhost:7357/assets/test-support.js, line 7468\n' }
    ...
not ok 2 Chrome 62.0 - global failure
    ---
        actual: >
            null
        stack: >
            http://localhost:7357/assets/test-support.js:7468
        message: >
            Uncaught TypeError: _ember.default.Debug.registerWarnHandler is not a function
        Log: |
    ...

It appears that the polyfill correctly works for the registerDeprecationHandler() function, but apparently registerWarnHandler() is still missing.

This surfaced in emberjs/ember-map-polyfill#9

/cc @rwjblue

[workmanw]

I'm open to options here. I don't mind making the addon more durable ... but it could also yield in unexpected behavior for users on 2.0.

@rwjblue would you consider adding registerWarnHandler to ember-debug-handlers-polyfill? I'd happily submit the PR myself.

[rwjblue]

Ya, it should have registerWarnHandlers for sure. I'm surprised I forgot it 😢